Remove error event listener before releasing connection back to pool #749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinod-hansda
requested review from
achrinza,
dhmlau and
marioestradarosa
as code owners
dhmlau
approved these changes
Mar 5, 2025
Member
dhmlau
left a comment
dhmlau
left a comment
There was a problem hiding this comment.
@vinod-hansda, thanks for your contribution. Your change LGTM.
Member
|
@vinod-hansda, could you please look into the commit linting error? Thanks. |
Contributor
Author
@dhmlau , I have updated the commit as suggested to fix the lint issue. |
…pool Signed-off-by: vinod-hansda <[email protected]>
Member
|
@vinod-hansda, I've squashed your commits, so that all the commit messages adhere to the commit format guideline. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpasses on your machine